Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance should check if upgrade was applied #4070

Closed
kostko opened this issue Jun 23, 2021 · 0 comments · Fixed by #4071
Closed

Governance should check if upgrade was applied #4070

kostko opened this issue Jun 23, 2021 · 0 comments · Fixed by #4071
Assignees
@kostko
Labels
c:consensus/tendermint Category: Tendermint-based consensus c:governance Category: governance service c:upgrade Category: upgrade infrastructure
Projects
Core 21.3

Comments

@kostko
Copy link
Member

kostko commented Jun 23, 2021

The governance service currently performs an EnsureCompatible sanity check which fails in case someone would manually cancel the upgrade descriptor installed by governance. But the compatibility check only checks the protocol versions and not other properties like upgrade handlers.

It should instead check if the appropriate upgrade descriptor is installed and has been executed and fail in case this is not the case, stopping the node for upgrade.
@kostko kostko added c:consensus/tendermint Category: Tendermint-based consensus c:governance Category: governance service c:upgrade Category: upgrade infrastructure labels Jun 23, 2021
@kostko kostko added this to Planned in Core 21.3 via automation Jun 23, 2021
@kostko kostko mentioned this issue Jun 23, 2021
Merged
@kostko kostko self-assigned this Jun 23, 2021
@kostko kostko moved this from Planned to In Progress in Core 21.3 Jun 23, 2021
Core 21.3 automation moved this from In Progress to Done Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:consensus/tendermint Category: Tendermint-based consensus c:governance Category: governance service c:upgrade Category: upgrade infrastructure
Projects
No open projects
Core 21.3
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/consensus/tendermint/apps/governance: Ensure upgrade is in progress oasisprotocol/oasis-core
1 participant
@kostko