Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/storage: Force checkpoint sync when block info unavailable #4080

Merged
merged 7 commits into from
Jun 25, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 24, 2021

No description provided.

@kostko kostko force-pushed the kostko/fix/storage-cons-state-sync-cp branch from b73c51e to d7d22d2 Compare June 24, 2021 19:03
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #4080 (384d90f) into master (0036da8) will decrease coverage by 0.35%.
The diff coverage is 38.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4080      +/-   ##
==========================================
- Coverage   66.78%   66.43%   -0.36%     
==========================================
  Files         391      411      +20     
  Lines       38138    42313    +4175     
==========================================
+ Hits        25472    28110    +2638     
- Misses       9017    10227    +1210     
- Partials     3649     3976     +327     
Impacted Files Coverage Δ
go/beacon/api/api.go 38.88% <ø> (ø)
go/common/crypto/mrae/api/api.go 20.00% <ø> (ø)
...ommon/crypto/signature/signers/file/file_signer.go 52.05% <ø> (ø)
...n/crypto/signature/signers/memory/memory_signer.go 62.85% <0.00%> (-13.01%) ⬇️
go/common/badger/migrate.go 4.00% <4.00%> (ø)
go/common/badger/helpers.go 34.61% <11.42%> (-47.74%) ⬇️
go/beacon/api/grpc.go 17.31% <17.31%> (ø)
go/common/crypto/tls/cert.go 57.44% <50.00%> (-1.46%) ⬇️
go/common/crypto/signature/signature.go 48.84% <57.14%> (+2.96%) ⬆️
go/common/crypto/slip10/slip10.go 65.51% <65.51%> (ø)
... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae86b4...384d90f. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/storage-cons-state-sync-cp branch from d02ad96 to 9b9e56b Compare June 25, 2021 11:35
@kostko kostko marked this pull request as ready for review June 25, 2021 11:36
@kostko kostko force-pushed the kostko/fix/storage-cons-state-sync-cp branch from 8d69e84 to 02c33dd Compare June 25, 2021 11:47
Previously if the node used consensus state sync it would fail to receive any
updates for the various descriptors until the descriptors were updated after
the state sync checkpoint.
@kostko kostko force-pushed the kostko/fix/storage-cons-state-sync-cp branch from 02c33dd to 742d63b Compare June 25, 2021 12:04
@kostko kostko merged commit b71bbb5 into master Jun 25, 2021
@kostko kostko deleted the kostko/fix/storage-cons-state-sync-cp branch June 25, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants