Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/executor: skip proposing timeout if batch received during timeout #4083

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 25, 2021

No description provided.

@ptrus ptrus force-pushed the ptrus/fix/propose-timeout-delay branch from d26bde1 to 5ebfea7 Compare June 25, 2021 09:49
@ptrus ptrus changed the title go/worker/executor: skip timeout if batch received during timeout go/worker/executor: skip proposing timeout if batch received during timeout Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #4083 (5ebfea7) into master (99abb0f) will decrease coverage by 0.50%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4083      +/-   ##
==========================================
- Coverage   66.92%   66.41%   -0.51%     
==========================================
  Files         411      411              
  Lines       42202    42214      +12     
==========================================
- Hits        28244    28038     -206     
- Misses       9949    10206     +257     
+ Partials     4009     3970      -39     
Impacted Files Coverage Δ
go/worker/compute/executor/committee/node.go 67.57% <38.46%> (-1.29%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 0.00% <0.00%> (-67.13%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 18.51% <0.00%> (-44.45%) ⬇️
go/keymanager/api/policy_sgx.go 23.07% <0.00%> (-15.39%) ⬇️
go/storage/api/context.go 86.36% <0.00%> (-13.64%) ⬇️
...nsensus/tendermint/apps/beacon/state/state_pvss.go 69.23% <0.00%> (-7.70%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 57.22% <0.00%> (-6.63%) ⬇️
go/oasis-node/cmd/keymanager/keymanager.go 42.77% <0.00%> (-4.82%) ⬇️
go/common/grpc/grpc.go 80.59% <0.00%> (-4.61%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99abb0f...5ebfea7. Read the comment docs.

@ptrus ptrus merged commit 4ae86b4 into master Jun 25, 2021
@ptrus ptrus deleted the ptrus/fix/propose-timeout-delay branch June 25, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants