Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/ias-proxy: remove use genesis option #4098

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 30, 2021

This was used long ago, not needed anymore.

I guess it's technically a breaking change.

@ptrus ptrus force-pushed the ptrus/feature/remove-ias-genesis branch from eb61816 to 12f77c3 Compare June 30, 2021 06:10
@ptrus ptrus force-pushed the ptrus/feature/remove-ias-genesis branch from 12f77c3 to 79cad76 Compare June 30, 2021 06:10
@ptrus ptrus marked this pull request as ready for review June 30, 2021 06:12
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #4098 (79cad76) into master (2391dab) will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4098      +/-   ##
==========================================
- Coverage   67.13%   66.53%   -0.60%     
==========================================
  Files         411      410       -1     
  Lines       42320    42292      -28     
==========================================
- Hits        28412    28141     -271     
- Misses       9928    10165     +237     
- Partials     3980     3986       +6     
Impacted Files Coverage Δ
go/oasis-node/cmd/ias/proxy.go 46.51% <ø> (-4.25%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 18.51% <0.00%> (-44.45%) ⬇️
go/keymanager/api/policy_sgx.go 23.07% <0.00%> (-15.39%) ⬇️
go/storage/api/context.go 86.36% <0.00%> (-13.64%) ⬇️
go/runtime/host/sandbox/sandbox.go 69.76% <0.00%> (-11.25%) ⬇️
go/storage/api/root_cache.go 75.55% <0.00%> (-8.89%) ⬇️
go/common/sgx/aesm/aesm.go 62.61% <0.00%> (-8.42%) ⬇️
...nsensus/tendermint/apps/beacon/state/state_pvss.go 69.23% <0.00%> (-7.70%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 57.22% <0.00%> (-6.63%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2391dab...79cad76. Read the comment docs.

@ptrus ptrus merged commit e9fbf29 into master Jun 30, 2021
@ptrus ptrus deleted the ptrus/feature/remove-ias-genesis branch June 30, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants