runtime: Replace serde-cbor with oasis-cbor #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/oasis-cbor
branch
4 times, most recently
from
458bb3a
to
a785d69
Compare
kostko
changed the title
kostko
force-pushed
the
kostko/feature/oasis-cbor
branch
2 times, most recently
from
6811ed7
to
69c4631
Compare
Codecov Report
@@ Coverage Diff @@
## master #4133 +/- ##
==========================================
- Coverage 69.18% 68.65% -0.54%
==========================================
Files 411 410 -1
Lines 47363 47250 -113
==========================================
- Hits 32770 32440 -330
- Misses 10556 10790 +234
+ Partials 4037 4020 -17
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/oasis-cbor
branch
from
69c4631
to
5efb439
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
Yawning
approved these changes
Jul 19, 2021
ptrus
reviewed
Jul 19, 2021
| @@ -161,8 +190,8 @@ pub enum Body { | |||
| header: Header, | |||
| epoch: EpochTime, | |||
| method: String, | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| args: Option<cbor::Value>, | |||
| #[cbor(optional)] | |||
ptrus
approved these changes
Jul 19, 2021
kostko
force-pushed
the
kostko/feature/oasis-cbor
branch
from
5efb439
to
56c9a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes two cleanup commits from #4101.
TODO