Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/21.2.x] upgrade/migrations: consensus parameters upgrade handler #4180

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Aug 5, 2021

@ptrus ptrus changed the title upgrade/migrations: consensus parameters upgrade handler [stable/21.2.x] upgrade/migrations: consensus parameters upgrade handler Aug 5, 2021
go/upgrade/migrations/consensus_parameters.go Outdated Show resolved Hide resolved
go/upgrade/migrations/consensus_parameters.go Outdated Show resolved Hide resolved
go/upgrade/migrations/consensus_parameters.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/consensus-params-update-2021-08 branch 2 times, most recently from 0fc20ff to a10f6a3 Compare August 6, 2021 09:05
@ptrus ptrus marked this pull request as ready for review August 6, 2021 09:08
@ptrus ptrus requested a review from kostko August 6, 2021 09:09
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #4180 (a10f6a3) into stable/21.2.x (3c22b85) will decrease coverage by 0.53%.
The diff coverage is 63.85%.

❗ Current head a10f6a3 differs from pull request most recent head 53e4231. Consider uploading reports for the commit 53e4231 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           stable/21.2.x    #4180      +/-   ##
=================================================
- Coverage          69.20%   68.67%   -0.54%     
=================================================
  Files                414      415       +1     
  Lines              47428    47511      +83     
=================================================
- Hits               32822    32626     -196     
- Misses             10567    10855     +288     
+ Partials            4039     4030       -9     
Impacted Files Coverage Δ
go/roothash/api/api.go 84.94% <ø> (ø)
go/staking/api/api.go 62.82% <ø> (ø)
go/upgrade/migrations/consensus_parameters.go 56.86% <56.86%> (ø)
go/consensus/tendermint/roothash/roothash.go 69.57% <60.00%> (-0.11%) ⬇️
go/roothash/api/grpc.go 38.29% <64.70%> (+2.62%) ⬆️
go/consensus/tendermint/apps/roothash/query.go 91.30% <100.00%> (+0.82%) ⬆️
go/roothash/tests/tester.go 90.17% <100.00%> (+0.14%) ⬆️
go/oasis-node/cmd/ias/auth_registry.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f629e16...53e4231. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/consensus-params-update-2021-08 branch from a10f6a3 to 53e4231 Compare August 6, 2021 13:28
@ptrus ptrus enabled auto-merge August 6, 2021 13:32
@ptrus ptrus merged commit b11e5ec into stable/21.2.x Aug 6, 2021
@ptrus ptrus deleted the ptrus/feature/consensus-params-update-2021-08 branch August 6, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants