Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Deprecate transaction::MethodDispatcher #4198

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Aug 11, 2021

By deprecate I mean, move into the simple-keyvalue runtime's main.rs,
preserving existing functionality in the worst possible way.

Part of #3572

@Yawning Yawning force-pushed the yawning/cleanup/method-dispatcher branch from 5afefdd to 08648d8 Compare August 11, 2021 12:11
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #4198 (3fdac0d) into master (5a88c9b) will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4198      +/-   ##
==========================================
- Coverage   69.28%   68.74%   -0.54%     
==========================================
  Files         411      411              
  Lines       47420    47420              
==========================================
- Hits        32857    32601     -256     
- Misses      10525    10795     +270     
+ Partials     4038     4024      -14     
Impacted Files Coverage Δ
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 71.06% <0.00%> (-9.90%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 59.34% <0.00%> (-6.60%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-6.37%) ⬇️
go/oasis-node/cmd/keymanager/keymanager.go 45.70% <0.00%> (-5.27%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a88c9b...3fdac0d. Read the comment docs.

@Yawning Yawning force-pushed the yawning/cleanup/method-dispatcher branch from 08648d8 to f74c6b5 Compare August 11, 2021 12:52
@Yawning Yawning marked this pull request as ready for review August 11, 2021 12:52
.changelog/4198.internal.md Outdated Show resolved Hide resolved
tests/runtimes/simple-keyvalue/src/main.rs Outdated Show resolved Hide resolved
tests/runtimes/simple-keyvalue/src/main.rs Outdated Show resolved Hide resolved
By deprecate I mean, move into the simple-keyvalue runtime's main.rs,
preserving existing functionality in the worst possible way.
@Yawning Yawning force-pushed the yawning/cleanup/method-dispatcher branch from f74c6b5 to 3fdac0d Compare August 12, 2021 12:44
@Yawning Yawning enabled auto-merge August 12, 2021 13:47
@Yawning Yawning merged commit 3184483 into master Aug 13, 2021
@Yawning Yawning deleted the yawning/cleanup/method-dispatcher branch August 13, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants