-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/scheduler: remove debug static validators option #4222
Conversation
@@ -1210,24 +1202,4 @@ WaitLoop: | |||
case <-time.After(recvTimeout): | |||
t.Fatalf("failed to receive roothash block") | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot really test freezing with a single validator. This should either be tested in an e2e test with multiple validators or if we added an option for freezing to: "freeze the node, but allow manually unfreezing in the first epoch already".
Will open a follow up issue for this.
20360ad
to
dc1dfd6
Compare
Codecov Report
@@ Coverage Diff @@
## master #4222 +/- ##
==========================================
- Coverage 69.16% 68.67% -0.50%
==========================================
Files 411 411
Lines 47514 47549 +35
==========================================
- Hits 32861 32652 -209
- Misses 10596 10848 +252
+ Partials 4057 4049 -8
Continue to review full report at Codecov.
|
dc1dfd6
to
07537ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that since this option was omitempty
, this shouldn't affect the chain context? Would be great to test that this works on testnet just to be sure.
07537ee
to
f95ac4d
Compare
Yeah i think this should work, but i'll backport this and test on a testnet node. |
Started a fresh node built on this branch on testnet and is syncing 👍 - so the chain context stayed the same.
|
Fixes: #4215