go/runtime: Add key manager EnclaveRPC support to client runtime hosts #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
kostko
force-pushed
the
kostko/fix/client-rt-host-keymgr
branch
3 times, most recently
from
c3f96d9
to
d872808
Compare
Previously runtimes hosted on client nodes were not able to issue EnclaveRPC requests as the endpoint was not implemented in the handler. This unifies the handler implementations between the client and compute nodes and makes sure that key manager requests are possible (of course client nodes will only be able to request public keys).
kostko
force-pushed
the
kostko/fix/client-rt-host-keymgr
branch
from
d872808
to
cea23e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4244 +/- ##
==========================================
- Coverage 69.03% 68.65% -0.39%
==========================================
Files 408 408
Lines 46976 46990 +14
==========================================
- Hits 32430 32261 -169
- Misses 10535 10738 +203
+ Partials 4011 3991 -20
Continue to review full report at Codecov.
|
ptrus
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously runtimes hosted on client nodes were not able to issue EnclaveRPC
requests as the endpoint was not implemented in the handler. This unifies the
handler implementations between the client and compute nodes and makes sure that
key manager requests are possible (of course client nodes will only be able to
request public keys).
Also removes the EnclaveRPC client interface as the idea is to go through runtime
queries (as the SDK now supports using the key manager). Note that the client part
of EnclaveRPC transport was already removed when doing the gRPC refactor.