Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/storage/api: Handle context cancellation in receiveWriteLogIterator #4292

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Oct 2, 2021

Exposed by fix for memory leak in #4290, the receiveWriteLogIterator did not handle context cancellation correctly and instead spinned forever.

Also see #4263.

@kostko kostko added c:storage Category: storage c:bug Category: bug labels Oct 2, 2021
@kostko kostko force-pushed the kostko/fix/storage-grpc-writelog-recv branch from fcdf143 to a7719a2 Compare October 2, 2021 20:31
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #4292 (a7719a2) into master (3e4ec06) will decrease coverage by 0.65%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4292      +/-   ##
==========================================
- Coverage   69.20%   68.54%   -0.66%     
==========================================
  Files         411      411              
  Lines       47215    47217       +2     
==========================================
- Hits        32675    32367     -308     
- Misses      10537    10820     +283     
- Partials     4003     4030      +27     
Impacted Files Coverage Δ
go/storage/api/grpc.go 67.79% <28.57%> (-1.87%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/storage/mkvs/writelog/iterator.go 76.36% <0.00%> (-16.37%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.03% <0.00%> (-9.90%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-8.19%) ⬇️
go/runtime/host/protocol/connection.go 62.16% <0.00%> (-6.95%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
go/storage/api/mux.go 56.34% <0.00%> (-6.35%) ⬇️
...nsensus/tendermint/apps/beacon/state/state_pvss.go 75.00% <0.00%> (-6.25%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4ec06...a7719a2. Read the comment docs.

@kostko kostko merged commit a9e6e01 into master Oct 2, 2021
@kostko kostko deleted the kostko/fix/storage-grpc-writelog-recv branch October 2, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant