Remove separate storage nodes #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
added
c:roothash
kostko
force-pushed
the
kostko/feature/executor-v2
branch
10 times, most recently
from
03663e9
to
0669c4c
Compare
kostko
force-pushed
the
kostko/feature/executor-v2
branch
from
0669c4c
to
8bc8ebf
Compare
Codecov Report
@@ Coverage Diff @@
## master #4308 +/- ##
==========================================
- Coverage 68.85% 68.83% -0.02%
==========================================
Files 413 414 +1
Lines 47070 46309 -761
==========================================
- Hits 32408 31879 -529
+ Misses 10681 10516 -165
+ Partials 3981 3914 -67
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/executor-v2
branch
3 times, most recently
from
dae76c9
to
0b5b852
Compare
Yawning
reviewed
Dec 6, 2021
| @@ -504,20 +492,6 @@ func VerifyRegisterNodeArgs( // nolint: gocyclo | |||
| return nil, nil, fmt.Errorf("%w: expiration period greater than allowed", ErrInvalidArgument) | |||
| } | |||
|
|
|||
| // Make sure that a node has at least one valid role. | |||
There was a problem hiding this comment.
Note: This was moved to node.ValidateBasic
| ErrTxnSchedSigInvalid = p2pError.Permanent(errors.New(moduleName, 12, "roothash/commitment: txn scheduler signature invalid")) | ||
| ErrInvalidMessages = p2pError.Permanent(errors.New(moduleName, 13, "roothash/commitment: invalid messages")) | ||
| ErrBadStorageReceipts = errors.New(moduleName, 14, "roothash/commitment: bad storage receipts") | ||
| // Error code 12 is reserved for future use. |
There was a problem hiding this comment.
Reserved for future use, or reserved to never be used again? I guess we can reuse them after the next upgrade...
kostko
force-pushed
the
kostko/feature/executor-v2
branch
2 times, most recently
from
a138445
to
73df582
Compare
Previously compute was a "super role" that a node would register for and the scheduler would then elect into subroles like executor, txnscheduler, merge but with the changed architecture compute basically equals executor (merge has been gone for a while and txnscheduler now rotates within the executor committee). |
kostko
force-pushed
the
kostko/feature/executor-v2
branch
from
73df582
to
b3b669c
Compare
It is no longer used anywhere and should be removed.
Previously this used a whole common committee node for each client runtime that was using the key manager.
kostko
force-pushed
the
kostko/feature/executor-v2
branch
2 times, most recently
from
104d350
to
2499ebb
Compare
Yawning
reviewed
Jan 3, 2022
kostko
force-pushed
the
kostko/feature/executor-v2
branch
3 times, most recently
from
c62a630
to
27a21ce
Compare
kostko
force-pushed
the
kostko/feature/executor-v2
branch
3 times, most recently
from
b4021fc
to
5f0194c
Compare
|
Multiple runs of long-term tests seem to pass now, running one more on the latest commit. |
The cache is populated when the pool is cleared and is only used when resolving known batches for faster resolution after epoch transitions.
kostko
force-pushed
the
kostko/feature/executor-v2
branch
from
5f0194c
to
4a9c33f
Compare
|
Latest long-term test run has been successful. |
Yawning
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the separate storage committee and makes all compute nodes always imply storage as well. A notion of runtime mode is introduced which can be one of none, compute, keymanager, client and client-stateless. Storage receipts are removed and executor commitments are used as storage availability commitments as well. An additional Byzantine scenario is added where a faulty proposer generates bogus batches by including transactions that nobody else has.
The structure of proposals is changed so that executor workers don't need to download transactions again, but instead use the existing P2P transaction dispatch mechanism.
Also fixes #3905.
Note that this change is consensus-breaking since it changes the committee scheduler and registry.
TODO
Explicit transaction requests for peers in case of missing transaction hashes.