Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/history: Limit batch size when pruning rounds #4345

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Nov 4, 2021

No description provided.

@kostko kostko added c:runtime Category: runtime c:bug Category: bug labels Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #4345 (c01cd26) into master (eb49625) will decrease coverage by 0.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4345      +/-   ##
==========================================
- Coverage   69.31%   68.53%   -0.78%     
==========================================
  Files         411      411              
  Lines       47417    47417              
==========================================
- Hits        32866    32499     -367     
- Misses      10543    10868     +325     
- Partials     4008     4050      +42     
Impacted Files Coverage Δ
go/runtime/history/prune.go 82.75% <100.00%> (ø)
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/storage/api/context.go 87.87% <0.00%> (-12.13%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.03% <0.00%> (-11.36%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/consensus/tendermint/apps/staking/auth.go 70.37% <0.00%> (-7.41%) ⬇️
go/runtime/host/protocol/connection.go 65.25% <0.00%> (-7.34%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb49625...c01cd26. Read the comment docs.

@kostko kostko merged commit 3f28a5c into master Nov 4, 2021
@kostko kostko deleted the kostko/fix/rt-prune-loop branch November 4, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:runtime Category: runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants