Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/storage/mkvs: Don't fail sanity check for equal roots #4381

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Nov 30, 2021

In case the state root did not change, a write log is empty and so the
sanity check should not require that it exists.

@kostko kostko added c:storage Category: storage c:bug Category: bug labels Nov 30, 2021
In case the state root did not change, a write log is empty and so the
sanity check should not require that it exists.
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #4381 (ae69a9b) into master (386130b) will decrease coverage by 0.43%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4381      +/-   ##
==========================================
- Coverage   69.03%   68.60%   -0.44%     
==========================================
  Files         411      411              
  Lines       47436    47437       +1     
==========================================
- Hits        32749    32543     -206     
- Misses      10647    10848     +201     
- Partials     4040     4046       +6     
Impacted Files Coverage Δ
go/storage/mkvs/db/badger/check.go 63.28% <50.00%> (+0.28%) ⬆️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.03% <0.00%> (-9.90%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-6.37%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 65.71% <0.00%> (-5.72%) ⬇️
go/runtime/host/protocol/connection.go 62.16% <0.00%> (-3.87%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386130b...ae69a9b. Read the comment docs.

@kostko kostko merged commit 9816de7 into master Nov 30, 2021
@kostko kostko deleted the kostko/fix/storage-check-wl branch November 30, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants