Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Propagate panics during transaction/local RPC/policy dispatch #4386

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Dec 3, 2021

A panic during transaction/local RPC/policy dispatch signals a serious problem
so it should be propagated and the runtime should crash to force state reset.

@kostko kostko added the c:runtime Category: runtime label Dec 3, 2021
A panic during transaction/local RPC/policy dispatch signals a serious problem
so it should be propagated and the runtime should crash to force state reset.
@kostko kostko force-pushed the kostko/fix/rt-propagate-tx-panics branch from 7f5b47a to 8fc7e21 Compare December 3, 2021 08:26
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #4386 (8fc7e21) into master (9816de7) will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4386      +/-   ##
==========================================
- Coverage   69.01%   68.64%   -0.38%     
==========================================
  Files         411      411              
  Lines       47437    47437              
==========================================
- Hits        32740    32564     -176     
- Misses      10651    10836     +185     
+ Partials     4046     4037       -9     
Impacted Files Coverage Δ
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/storage/api/context.go 87.87% <0.00%> (-12.13%) ⬇️
go/storage/api/root_cache.go 75.00% <0.00%> (-8.34%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
go/runtime/host/sandbox/sandbox.go 71.06% <0.00%> (-6.60%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-6.37%) ⬇️
go/storage/api/mux.go 56.34% <0.00%> (-6.35%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9816de7...8fc7e21. Read the comment docs.

@kostko kostko merged commit c660d0c into master Dec 3, 2021
@kostko kostko deleted the kostko/fix/rt-propagate-tx-panics branch December 3, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime Category: runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants