Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/storage: Checkpoint correct round on consensus checkpoint #4387

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Dec 7, 2021

No description provided.

@kostko kostko added c:storage Category: storage c:bug Category: bug labels Dec 7, 2021
@kostko kostko force-pushed the kostko/fix/rt-storage-state-sync-3 branch from 62fd8bf to b2f4f0d Compare December 7, 2021 10:20
@kostko kostko marked this pull request as ready for review December 7, 2021 10:21
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #4387 (1ad0356) into master (c660d0c) will decrease coverage by 0.45%.
The diff coverage is 53.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4387      +/-   ##
==========================================
- Coverage   69.14%   68.68%   -0.46%     
==========================================
  Files         411      411              
  Lines       47437    47510      +73     
==========================================
- Hits        32798    32633     -165     
- Misses      10608    10832     +224     
- Partials     4031     4045      +14     
Impacted Files Coverage Δ
go/runtime/client/client.go 72.24% <33.33%> (-1.84%) ⬇️
go/worker/storage/committee/node.go 76.10% <54.16%> (+0.11%) ⬆️
go/storage/mkvs/checkpoint/checkpointer.go 81.62% <100.00%> (+0.40%) ⬆️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/worker/keymanager/watcher.go 65.21% <0.00%> (-10.15%) ⬇️
go/runtime/host/sandbox/sandbox.go 71.79% <0.00%> (-9.90%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c660d0c...1ad0356. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/rt-storage-state-sync-3 branch from b2f4f0d to 1ad0356 Compare December 7, 2021 11:36
@kostko kostko merged commit 81fa2dd into master Dec 7, 2021
@kostko kostko deleted the kostko/fix/rt-storage-state-sync-3 branch December 7, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants