go/storage/api: Make metrics wrapper return proper types #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/rt-client-lsb-nil
branch
from
d4ff038
to
19e05be
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
Yawning
approved these changes
Dec 24, 2021
Previously the metrics wrapper tried to support all of the different backend interfaces, causing problems with places that perform type checks to determine which backend type is in use. The metrics wrapper is now changed to return a type matching the wrapped backend type.
kostko
force-pushed
the
kostko/fix/rt-client-lsb-nil
branch
from
8be3d58
to
8b5073b
Compare
kostko
changed the title
|
Updated the PR to fix the metrics wrapper instead. |
ptrus
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.