Add support for runtime schedule control #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
added
c:runtime/compute
kostko
force-pushed
the
kostko/feature/rt-schedule-control
branch
2 times, most recently
from
cc3d529
to
bcb893d
Compare
kostko
force-pushed
the
kostko/feature/incoming-rt-messages
branch
from
0f54266
to
37b80a7
Compare
kostko
force-pushed
the
kostko/feature/rt-schedule-control
branch
from
bcb893d
to
029b27d
Compare
ptrus
reviewed
Jan 21, 2022
kostko
force-pushed
the
kostko/feature/rt-schedule-control
branch
from
029b27d
to
0c1389c
Compare
ptrus
reviewed
Jan 25, 2022
| defer q.Unlock() | ||
|
|
||
| var ( | ||
| batch []*transaction.CheckedTransaction |
There was a problem hiding this comment.
Might make sense pre-allocating batch here (with length 0)
kostko
force-pushed
the
kostko/feature/incoming-rt-messages
branch
from
37b80a7
to
3a18290
Compare
kostko
force-pushed
the
kostko/feature/rt-schedule-control
branch
4 times, most recently
from
6dfd433
to
540aaab
Compare
pro-wh
reviewed
Jan 27, 2022
go/runtime/scheduling/simple/txpool/priorityqueue/priority_queue.go
Outdated
Show resolved
Hide resolved
kostko
force-pushed
the
kostko/feature/incoming-rt-messages
branch
4 times, most recently
from
6a038f4
to
c95e5a1
Compare
Base automatically changed from
kostko/feature/incoming-rt-messages
to
master
January 28, 2022 10:28
kostko
force-pushed
the
kostko/feature/rt-schedule-control
branch
from
540aaab
to
ca07ed3
Compare
kostko
force-pushed
the
kostko/feature/rt-schedule-control
branch
2 times, most recently
from
9d265b4
to
a0975f2
Compare
kostko
force-pushed
the
kostko/feature/rt-schedule-control
branch
from
a0975f2
to
a6e547e
Compare
Codecov Report
@@ Coverage Diff @@
## master #4438 +/- ##
==========================================
+ Coverage 68.66% 68.87% +0.21%
==========================================
Files 415 415
Lines 46571 46759 +188
==========================================
+ Hits 31976 32204 +228
+ Misses 10635 10609 -26
+ Partials 3960 3946 -14
Continue to review full report at Codecov.
|
matevz
reviewed
Jan 31, 2022
| hashes := make([]hash.Hash, len(batch)) | ||
| for i, tx := range batch { | ||
| hashes[i] = tx.Hash() | ||
| hashes := make([]hash.Hash, 0, len(batch)) |
There was a problem hiding this comment.
Nit: Since you're inserting duplicates, should this be
Suggested change
| hashes := make([]hash.Hash, 0, len(batch)) | |
| hashes := make([]hash.Hash, 0, 2*len(batch)) |
Or just remove the capacity entirely.
Yawning
approved these changes
Jan 31, 2022
| @@ -254,6 +259,18 @@ func (c *connection) Close() { | |||
| c.quitWg.Wait() | |||
| } | |||
|
|
|||
| // Implements Connection. | |||
| func (c *connection) GetInfo(ctx context.Context) (*RuntimeInfoResponse, error) { | |||
| c.Lock() | |||
There was a problem hiding this comment.
Can't this just use defer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4415.
Also adds functionality needed for #4436.
TODO