Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Downtime-less runtime updates #4449

Merged
merged 5 commits into from
Feb 24, 2022
Merged

feature: Downtime-less runtime updates #4449

merged 5 commits into from
Feb 24, 2022

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jan 25, 2022 •
edited

  • Document the design
  • Implement the code
  • Implement the tests

@Yawning Yawning mentioned this pull request Jan 25, 2022
Closed
@Yawning Yawning force-pushed the yawning/feature/runtime-updates branch 3 times, most recently from 61ccbb7 to d74cc40 Compare February 7, 2022 09:08
@Yawning Yawning force-pushed the yawning/feature/runtime-updates branch 9 times, most recently from f61a854 to 5f26b2f Compare February 23, 2022 15:08
@kostko kostko force-pushed the yawning/feature/runtime-updates branch 3 times, most recently from 0946b46 to d35381d Compare February 24, 2022 09:29
@codecov
Copy link

codecov bot commented Feb 24, 2022 •
edited

Codecov Report

Merging #4449 (d35381d) into master (cdd4b1f) will decrease coverage by 0.07%.
The diff coverage is 58.24%.

❗ Current head d35381d differs from pull request most recent head f82385b. Consider uploading reports for the commit f82385b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4449      +/-   ##
==========================================
- Coverage   68.01%   67.93%   -0.08%     
==========================================
  Files         421      422       +1     
  Lines       46985    47357     +372     
==========================================
+ Hits        31957    32173     +216     
- Misses      11077    11213     +136     
- Partials     3951     3971      +20
Impacted Files Coverage Δ
go/runtime/host/sandbox/sandbox.go 59.15% <ø> (ø)
go/runtime/nodes/runtime.go 6.36% <0.00%> (ø)
go/worker/keymanager/init.go 72.54% <0.00%> (-2.97%) ⬇️
go/worker/storage/committee/node.go 75.58% <ø> (-0.07%) ⬇️
go/roothash/api/commitment/pool.go 68.57% <13.33%> (-3.24%) ⬇️
go/worker/keymanager/worker.go 63.92% <33.33%> (-0.81%) ⬇️
go/registry/api/api.go 55.88% <36.29%> (-3.30%) ⬇️
go/consensus/tendermint/apps/keymanager/genesis.go 58.18% <50.00%> (-1.44%) ⬇️
go/consensus/tendermint/apps/registry/genesis.go 46.95% <50.00%> (-0.37%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 71.60% <50.00%> (+0.27%) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8358f...f82385b. Read the comment docs.

@Yawning Yawning force-pushed the yawning/feature/runtime-updates branch from d35381d to 1f95c06 Compare February 24, 2022 10:47
@Yawning Yawning marked this pull request as ready for review February 24, 2022 10:47
@Yawning Yawning force-pushed the yawning/feature/runtime-updates branch from 1f95c06 to 9def180 Compare February 24, 2022 10:59
ptrus
ptrus reviewed Feb 24, 2022
View reviewed changes
go/common/node/node.go Show resolved Hide resolved
go/registry/api/runtime.go Outdated Show resolved Hide resolved
go/registry/api/runtime.go Outdated Show resolved Hide resolved
kostko
kostko reviewed Feb 24, 2022
View reviewed changes
go/registry/api/api.go Outdated Show resolved Hide resolved
go/registry/api/api_test.go
@@ -129,6 +129,7 @@ func TestVerifyNodeUpdate(t *testing.T) {
err: ErrNodeUpdateNotAllowed,
msg: "expired node consensus ID update should not be allowed",
},
// TODO: Add checks for runtime versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add these now?

go/registry/api/runtime.go Show resolved Hide resolved
go/runtime/registry/host.go Show resolved Hide resolved
@Yawning Yawning force-pushed the yawning/feature/runtime-updates branch from 9def180 to 06364b3 Compare February 24, 2022 12:16
@Yawning Yawning force-pushed the yawning/feature/runtime-updates branch from 06364b3 to 1af13ca Compare February 24, 2022 12:45
@Yawning Yawning force-pushed the yawning/feature/runtime-updates branch from 1af13ca to 2810414 Compare February 24, 2022 12:54
@Yawning Yawning force-pushed the yawning/feature/runtime-updates branch from 2810414 to f82385b Compare February 24, 2022 13:36
@Yawning Yawning merged commit ea48f8a into master Feb 24, 2022
@Yawning Yawning deleted the yawning/feature/runtime-updates branch February 24, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrus ptrus ptrus left review comments

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yawning @kostko @ptrus