Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/txpool: Refactor runtime scheduling queue #4477

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 14, 2022

  • Remove the algorithm field from the runtime descriptor (it is unused).
  • Refactor the runtime txpool as it can be simplified now that there is just one "algorithm".

@kostko kostko added the c:breaking/consensus Category: breaking consensus changes label Feb 14, 2022
@kostko kostko force-pushed the kostko/feature/rt-txpool-refactor branch 3 times, most recently from e57598d to 3310494 Compare February 14, 2022 17:25
@kostko kostko force-pushed the kostko/feature/rt-txpool-refactor branch from 3310494 to b4de534 Compare February 15, 2022 07:45
@kostko kostko marked this pull request as ready for review February 15, 2022 09:11
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #4477 (b4de534) into master (c9cecfb) will increase coverage by 0.07%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4477      +/-   ##
==========================================
+ Coverage   68.79%   68.87%   +0.07%     
==========================================
  Files         423      421       -2     
  Lines       47241    47174      -67     
==========================================
- Hits        32499    32489      -10     
+ Misses      10747    10697      -50     
+ Partials     3995     3988       -7     
Impacted Files Coverage Δ
go/registry/api/runtime.go 44.51% <ø> (+0.56%) ⬆️
go/registry/tests/tester.go 92.48% <ø> (-0.01%) ⬇️
go/runtime/txpool/txpool.go 83.59% <84.21%> (+3.39%) ⬆️
go/runtime/txpool/check_queue.go 84.61% <100.00%> (ø)
go/runtime/txpool/priority_queue.go 89.94% <100.00%> (ø)
go/consensus/tendermint/apps/beacon/genesis.go 63.63% <0.00%> (-6.07%) ⬇️
go/common/sgx/common.go 66.01% <0.00%> (-3.89%) ⬇️
go/consensus/tendermint/full/services.go 77.69% <0.00%> (-3.85%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 70.43% <0.00%> (-3.05%) ⬇️
go/common/grpc/grpc.go 83.43% <0.00%> (-2.37%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c795ad3...b4de534. Read the comment docs.

@@ -115,9 +112,6 @@ func (e *ExecutorParameters) ValidateBasic() error {

// TxnSchedulerParameters are parameters for the runtime transaction scheduler.
type TxnSchedulerParameters struct {
Copy link
Member

@ptrus ptrus Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, fixgenesis is not needed for this removal, as the old field will just get skipped when deserializing the json, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right.

@kostko kostko merged commit 39e5f61 into master Feb 15, 2022
@kostko kostko deleted the kostko/feature/rt-txpool-refactor branch February 15, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants