Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common: Report locally supported runtime host versions #4524

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 28, 2022

Fixes #4436

Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a change log fragment for liveliness as well and explain the output briefly?

@kostko kostko force-pushed the kostko/feature/improve-ctrl-status branch 2 times, most recently from 290a48f to 7cdfd06 Compare February 28, 2022 19:16
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #4524 (7cdfd06) into master (29835f7) will decrease coverage by 0.04%.
The diff coverage is 64.28%.

❗ Current head 7cdfd06 differs from pull request most recent head 8e28770. Consider uploading reports for the commit 8e28770 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4524      +/-   ##
==========================================
- Coverage   66.99%   66.94%   -0.05%     
==========================================
  Files         425      425              
  Lines       47728    47740      +12     
==========================================
- Hits        31976    31961      -15     
- Misses      11831    11855      +24     
- Partials     3921     3924       +3     
Impacted Files Coverage Δ
go/worker/common/committee/node.go 64.74% <28.57%> (-0.84%) ⬇️
go/worker/common/committee/group.go 80.58% <100.00%> (+0.58%) ⬆️
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/worker/common/p2p/dispatch.go 71.52% <0.00%> (-5.56%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/runtime/host/multi/multi.go 70.89% <0.00%> (-3.74%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 69.77% <0.00%> (-3.12%) ⬇️
go/worker/beacon/worker_vrf.go 64.34% <0.00%> (-1.74%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 73.91% <0.00%> (-1.09%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fe4ad...8e28770. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/improve-ctrl-status branch from 7cdfd06 to 491d354 Compare March 1, 2022 08:02
@kostko kostko disabled auto-merge March 1, 2022 08:26
@kostko kostko enabled auto-merge March 1, 2022 08:31
@kostko kostko merged commit 958ab3d into master Mar 1, 2022
@kostko kostko deleted the kostko/feature/improve-ctrl-status branch March 1, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report runtime version in oasis-node control status for runtime client nodes
3 participants