Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/bundle: Verify SGX signature if present #4542

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 5, 2022

No description provided.

@kostko kostko added the c:common Category: common libraries label Mar 5, 2022
@kostko kostko force-pushed the kostko/feature/bundle-verify-sgxsig branch from 49c1656 to 03a6306 Compare March 5, 2022 13:35
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #4542 (03a6306) into master (122cfdd) will increase coverage by 0.14%.
The diff coverage is 21.42%.

❗ Current head 03a6306 differs from pull request most recent head e00babe. Consider uploading reports for the commit e00babe to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4542      +/-   ##
==========================================
+ Coverage   66.92%   67.06%   +0.14%     
==========================================
  Files         424      424              
  Lines       47738    47752      +14     
==========================================
+ Hits        31948    32025      +77     
+ Misses      11851    11806      -45     
+ Partials     3939     3921      -18     
Impacted Files Coverage Δ
go/runtime/bundle/bundle.go 59.89% <21.42%> (-3.21%) ⬇️
go/consensus/tendermint/full/services.go 77.69% <0.00%> (-3.85%) ⬇️
go/runtime/registry/host.go 66.23% <0.00%> (-2.17%) ⬇️
go/worker/client/committee/node.go 75.48% <0.00%> (-1.30%) ⬇️
go/consensus/tendermint/apps/beacon/backend_vrf.go 58.89% <0.00%> (-0.85%) ⬇️
go/runtime/txpool/txpool.go 81.32% <0.00%> (-0.52%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 56.09% <0.00%> (-0.43%) ⬇️
.../consensus/tendermint/apps/registry/state/state.go 61.11% <0.00%> (ø)
...o/consensus/tendermint/apps/staking/state/state.go 64.48% <0.00%> (+0.27%) ⬆️
go/common/grpc/grpc.go 84.91% <0.00%> (+0.59%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2013aa1...e00babe. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/bundle-verify-sgxsig branch from 03a6306 to e00babe Compare March 5, 2022 20:35
@kostko kostko enabled auto-merge March 5, 2022 20:36
@kostko kostko merged commit 3cec515 into master Mar 5, 2022
@kostko kostko deleted the kostko/feature/bundle-verify-sgxsig branch March 5, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:common Category: common libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants