Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Commit check transaction results for subsequent batches #4557

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 9, 2022

No description provided.

@kostko kostko force-pushed the kostko/feature/checktx-commit branch 2 times, most recently from 1efa9c7 to 9cff00c Compare March 9, 2022 17:45
@kostko kostko force-pushed the kostko/feature/checktx-commit branch from 9cff00c to 0b33d89 Compare March 9, 2022 18:19
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #4557 (0b33d89) into master (c0f76e9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4557   +/-   ##
=======================================
  Coverage   66.98%   66.98%           
=======================================
  Files         425      425           
  Lines       47960    47960           
=======================================
+ Hits        32126    32128    +2     
+ Misses      11897    11887   -10     
- Partials     3937     3945    +8     
Impacted Files Coverage Δ
go/worker/common/committee/p2p.go 80.00% <0.00%> (-6.67%) ⬇️
go/consensus/api/submission.go 64.28% <0.00%> (-4.77%) ⬇️
go/common/sgx/common.go 66.01% <0.00%> (-3.89%) ⬇️
go/consensus/tendermint/apps/beacon/beacon.go 70.49% <0.00%> (-3.28%) ⬇️
go/worker/storage/p2p/sync/server.go 74.19% <0.00%> (-3.23%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 65.81% <0.00%> (-2.57%) ⬇️
go/runtime/txpool/txpool.go 81.58% <0.00%> (-2.56%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 68.81% <0.00%> (-2.16%) ⬇️
go/oasis-node/cmd/node/node.go 54.36% <0.00%> (-1.75%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c72fa6...0b33d89. Read the comment docs.

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed on slack, we'd like to try this

@kostko kostko merged commit 4f27925 into master Mar 10, 2022
@kostko kostko deleted the kostko/feature/checktx-commit branch March 10, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants