go/storage: reduce storage checkpointing #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/reduce-checkpointing
branch
2 times, most recently
from
b77f1e8
to
3f112cd
Compare
|
We can probably leave consensus checkpoints as they are since consensus state is fairly small. |
ptrus
requested review from
kostko,
Yawning,
peterjgilbert and
pro-wh
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4561 +/- ##
==========================================
- Coverage 66.97% 66.86% -0.11%
==========================================
Files 425 424 -1
Lines 47960 47958 -2
==========================================
- Hits 32119 32067 -52
- Misses 11905 11939 +34
- Partials 3936 3952 +16
Continue to review full report at Codecov.
|
kostko
reviewed
Mar 11, 2022
ptrus
force-pushed
the
ptrus/feature/reduce-checkpointing
branch
from
3f112cd
to
3ee5ec7
Compare
kostko
approved these changes
Mar 11, 2022
| paused := false | ||
|
|
||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| case <-ticker.C: | ||
| case <-time.After(random.GetRandomValueFromInterval(checkpointIntervalRandomizationFactor, rand.Float64(), c.cfg.CheckInterval)): |
There was a problem hiding this comment.
Could maybe move the inner value into a new variable initialized before the select statement to make it less cluttered.
ptrus
force-pushed
the
ptrus/feature/reduce-checkpointing
branch
from
3ee5ec7
to
3b195a3
Compare
ptrus
force-pushed
the
ptrus/feature/reduce-checkpointing
branch
from
3b195a3
to
ad009aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should the consensus checkpoints also be disabled by default?