Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/storage: Remove separate storage sync status store #4565

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 14, 2022

Previously the worker maintaned a separate store that kept information
about the progress of storage sync. Since it was a separate store this
could cause problems if it got out of sync (e.g. due to partial manual
copies). This should make the process more robust as there is only one
source of truth.

@kostko kostko force-pushed the kostko/fix/rt-storage-dbbehind-recover branch 2 times, most recently from f9d20f7 to b0ec491 Compare March 14, 2022 20:47
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #4565 (0d434bf) into master (0de481e) will increase coverage by 0.15%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #4565      +/-   ##
==========================================
+ Coverage   66.96%   67.11%   +0.15%     
==========================================
  Files         424      424              
  Lines       47970    47955      -15     
==========================================
+ Hits        32121    32183      +62     
+ Misses      11910    11842      -68     
+ Partials     3939     3930       -9     
Impacted Files Coverage Δ
go/oasis-node/cmd/node/node.go 56.00% <ø> (+1.63%) ⬆️
go/storage/mkvs/db/api/api.go 53.06% <0.00%> (ø)
go/worker/storage/worker.go 88.99% <50.00%> (+1.05%) ⬆️
go/worker/storage/committee/node.go 77.57% <96.42%> (+1.44%) ⬆️
go/consensus/tendermint/abci/prune.go 83.03% <100.00%> (+1.45%) ⬆️
go/consensus/tendermint/abci/state.go 75.36% <100.00%> (+1.60%) ⬆️
go/storage/mkvs/checkpoint/checkpointer.go 83.51% <100.00%> (+0.90%) ⬆️
go/storage/mkvs/db/badger/badger.go 70.28% <100.00%> (-0.05%) ⬇️
go/worker/client/service.go 70.58% <100.00%> (-0.38%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3eea7...0d434bf. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/rt-storage-dbbehind-recover branch from b0ec491 to e9e3906 Compare March 15, 2022 09:14
@kostko kostko changed the title go/worker/storage: Recover from sync state mismatch go/worker/storage: Remove separate storage sync status store Mar 15, 2022
@kostko kostko force-pushed the kostko/fix/rt-storage-dbbehind-recover branch 2 times, most recently from eddedd1 to 50fd730 Compare March 15, 2022 11:14
@kostko kostko marked this pull request as ready for review March 15, 2022 11:58
@kostko kostko requested a review from jberci March 15, 2022 11:58
Previously the worker maintaned a separate store that kept information
about the progress of storage sync. Since it was a separate store this
could cause problems if it got out of sync (e.g. due to partial manual
copies). This should make the process more robust as there is only one
source of truth.
@kostko kostko force-pushed the kostko/fix/rt-storage-dbbehind-recover branch from 50fd730 to 0d434bf Compare March 15, 2022 18:36
@kostko kostko merged commit d1f3fb3 into master Mar 16, 2022
@kostko kostko deleted the kostko/fix/rt-storage-dbbehind-recover branch March 16, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants