go/worker/registration: Clear deregister flag when deregistered #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
force-pushed
the
yawning/fix/shutdown-status
branch
from
ab716a3
to
8fc0c73
Compare
When gracefully halting the node after the node's registration expires, to ensure that the deregistration and shutdown occurs, the node will persist the fact that it is mid-shutdown in a flag. Previously, this flag had to be cleared manually by the node operator which, while serving to ensure that the node does not get restarted and re-register, is sub-optimal as it required manual intervention. Instead, if the node is deregistered cleanly, we will clear the flag under the assumption that the operator can configure whatever automation they are using to do the right thing.
Yawning
force-pushed
the
yawning/fix/shutdown-status
branch
from
fbb08de
to
afabfc6
Compare
Yawning
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4580 +/- ##
==========================================
- Coverage 67.08% 66.86% -0.23%
==========================================
Files 424 424
Lines 48030 48069 +39
==========================================
- Hits 32223 32141 -82
- Misses 11882 11982 +100
- Partials 3925 3946 +21
Continue to review full report at Codecov.
|
kostko
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gracefully halting the node after the node's registration
expires, to ensure that the deregistration and shutdown occurs,
the node will persist the fact that it is mid-shutdown in a flag.
Previously, this flag had to be cleared manually by the node operator
which, while serving to ensure that the node does not get restarted
and re-register, is sub-optimal as it required manual intervention.
Instead, if the node is deregistered cleanly, we will clear the flag
under the assumption that the operator can configure whatever
automation they are using to do the right thing.