-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/oasis-node/cmd: unsafe-reset preserve mkvs by default #4588
Conversation
229ff2f
to
748ffce
Compare
Also backport to 22.0.x and 21.3.x. |
oop gotta update oasis-test-runner |
748ffce
to
423b989
Compare
Codecov Report
@@ Coverage Diff @@
## master #4588 +/- ##
==========================================
+ Coverage 66.71% 66.86% +0.14%
==========================================
Files 427 427
Lines 48173 48173
==========================================
+ Hits 32141 32213 +72
+ Misses 12079 12023 -56
+ Partials 3953 3937 -16
Continue to review full report at Codecov.
|
tsk now this PR is stuck open even though it's merged |
oh good, commenting fixed it |
…port-4588 stable/21.3.x backport #4588
…port-4588 stable/22.0.x backport #4588
cross reference: https://app.clickup.com/t/294pfzp
Preserving the mkvs database is becoming the more common workflow, so we're changing the default to be true.
Use
--preserve.mkvs_database=false
to wipe the mkvs database as the previous default did.