Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd: unsafe-reset preserve mkvs by default #4588

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Mar 22, 2022

cross reference: https://app.clickup.com/t/294pfzp

Preserving the mkvs database is becoming the more common workflow, so we're changing the default to be true.

Use --preserve.mkvs_database=false to wipe the mkvs database as the previous default did.

@pro-wh pro-wh added the c:cli Category: command line interface label Mar 22, 2022
@kostko
Copy link
Member

kostko commented Mar 22, 2022

Also backport to 22.0.x and 21.3.x.

@pro-wh
Copy link
Contributor Author

pro-wh commented Mar 22, 2022

oop gotta update oasis-test-runner

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #4588 (423b989) into master (def2f97) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4588      +/-   ##
==========================================
+ Coverage   66.71%   66.86%   +0.14%     
==========================================
  Files         427      427              
  Lines       48173    48173              
==========================================
+ Hits        32141    32213      +72     
+ Misses      12079    12023      -56     
+ Partials     3953     3937      -16     
Impacted Files Coverage Δ
go/oasis-node/cmd/node/unsafe_reset.go 63.63% <100.00%> (ø)
go/storage/mkvs/lookup.go 75.00% <0.00%> (-4.17%) ⬇️
...nt/apps/supplementarysanity/supplementarysanity.go 77.61% <0.00%> (-2.99%) ⬇️
...nsensus/tendermint/apps/beacon/backend_insecure.go 58.24% <0.00%> (-2.20%) ⬇️
go/worker/compute/executor/committee/node.go 69.25% <0.00%> (-1.32%) ⬇️
go/worker/client/committee/node.go 73.54% <0.00%> (-1.30%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 65.27% <0.00%> (-1.26%) ⬇️
go/runtime/txpool/txpool.go 75.96% <0.00%> (-1.04%) ⬇️
...nsus/tendermint/apps/supplementarysanity/checks.go 47.08% <0.00%> (-0.98%) ⬇️
go/runtime/host/protocol/connection.go 69.17% <0.00%> (-0.76%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa52c4d...423b989. Read the comment docs.

@pro-wh pro-wh merged commit f515995 into master Mar 22, 2022
@pro-wh pro-wh deleted the pro-wh/feature/preserve branch March 22, 2022 20:27
@pro-wh
Copy link
Contributor Author

pro-wh commented Mar 22, 2022

tsk now this PR is stuck open even though it's merged

@pro-wh
Copy link
Contributor Author

pro-wh commented Mar 22, 2022

oh good, commenting fixed it

pro-wh added a commit that referenced this pull request Mar 23, 2022
pro-wh added a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants