Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: show dirtiness after regenerating protos #4598

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Mar 23, 2022

opened from #4509

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #4598 (3159207) into master (504af66) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 3159207 differs from pull request most recent head 97a20cc. Consider uploading reports for the commit 97a20cc to get more accurate results

@@            Coverage Diff             @@
##           master    #4598      +/-   ##
==========================================
- Coverage   66.49%   66.41%   -0.08%     
==========================================
  Files         428      428              
  Lines       48512    48512              
==========================================
- Hits        32256    32218      -38     
- Misses      12318    12349      +31     
- Partials     3938     3945       +7     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/worker/common/committee/p2p.go 70.00% <0.00%> (-16.67%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
go/common/crypto/signature/signer.go 94.73% <0.00%> (-1.76%) ⬇️
go/oasis-node/cmd/node/node.go 54.29% <0.00%> (-1.72%) ⬇️
go/worker/compute/executor/committee/node.go 72.37% <0.00%> (-1.62%) ⬇️
go/runtime/host/protocol/connection.go 70.67% <0.00%> (-1.51%) ⬇️
go/runtime/host/multi/multi.go 73.52% <0.00%> (-1.48%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0515a5...97a20cc. Read the comment docs.

@pro-wh pro-wh enabled auto-merge March 24, 2022 18:14
@pro-wh pro-wh merged commit bd5fd7e into master Mar 24, 2022
@pro-wh pro-wh deleted the pro-wh/feature/pbdiff branch March 24, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants