Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/crypto/signature: Add batch verification goodies #4602

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Mar 25, 2022

  • Raw signatures
  • Consensus transactions
  • Test cases

@Yawning Yawning force-pushed the yawning/feature/signed-batch-open branch 4 times, most recently from 9531ea5 to 0042eba Compare March 25, 2022 12:36
@Yawning Yawning marked this pull request as ready for review March 25, 2022 12:36
@Yawning Yawning force-pushed the yawning/feature/signed-batch-open branch from 0042eba to 737f07f Compare March 25, 2022 13:12
Having to process these serially probably really sucks.  Since we have
efficient batch verification, we might as well use it.
@Yawning Yawning force-pushed the yawning/feature/signed-batch-open branch from 737f07f to 1e923b7 Compare March 25, 2022 13:43
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #4602 (1e923b7) into master (f6b38e4) will decrease coverage by 0.00%.
The diff coverage is 58.69%.

@@            Coverage Diff             @@
##           master    #4602      +/-   ##
==========================================
- Coverage   66.37%   66.36%   -0.01%     
==========================================
  Files         428      429       +1     
  Lines       48512    48590      +78     
==========================================
+ Hits        32198    32249      +51     
- Misses      12361    12387      +26     
- Partials     3953     3954       +1     
Impacted Files Coverage Δ
go/consensus/api/transaction/transaction.go 38.23% <0.00%> (-10.37%) ⬇️
go/common/crypto/signature/batch_verification.go 85.48% <85.48%> (ø)
go/common/crypto/signature/signature.go 54.26% <100.00%> (+2.60%) ⬆️
.../worker/compute/executor/committee/transactions.go 63.46% <0.00%> (-19.24%) ⬇️
go/worker/common/p2p/txsync/client.go 50.00% <0.00%> (-8.34%) ⬇️
go/worker/common/p2p/txsync/server.go 65.38% <0.00%> (-3.85%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 65.27% <0.00%> (-2.52%) ⬇️
go/common/grpc/grpc.go 79.88% <0.00%> (-2.37%) ⬇️
go/runtime/host/multi/multi.go 73.52% <0.00%> (-2.21%) ⬇️
go/runtime/registry/host.go 66.23% <0.00%> (-2.17%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2811832...1e923b7. Read the comment docs.

@Yawning Yawning merged commit 02f7181 into master Mar 25, 2022
@Yawning Yawning deleted the yawning/feature/signed-batch-open branch March 25, 2022 15:02
kostko added a commit that referenced this pull request Mar 26, 2022
…kport-4602

[BACKPORT/22.0.x]: go/common/crypto/signature: Add batch verification goodies #4602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants