Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/compute: Always include resolved transactions #4633

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 4, 2022

No description provided.

@kostko kostko added the c:bug Category: bug label Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #4633 (12dd4f8) into master (4241698) will increase coverage by 0.04%.
The diff coverage is 80.64%.

❗ Current head 12dd4f8 differs from pull request most recent head 0fbc915. Consider uploading reports for the commit 0fbc915 to get more accurate results

@@            Coverage Diff             @@
##           master    #4633      +/-   ##
==========================================
+ Coverage   66.96%   67.01%   +0.04%     
==========================================
  Files         431      431              
  Lines       48769    48799      +30     
==========================================
+ Hits        32659    32701      +42     
+ Misses      12075    12062      -13     
- Partials     4035     4036       +1     
Impacted Files Coverage Δ
go/worker/compute/executor/committee/batch.go 72.00% <64.70%> (-3.76%) ⬇️
.../worker/compute/executor/committee/transactions.go 86.15% <100.00%> (+3.46%) ⬆️
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.15% <0.00%> (-2.90%) ⬇️
go/worker/beacon/worker_vrf.go 64.34% <0.00%> (-1.74%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 55.25% <0.00%> (-1.27%) ⬇️
go/registry/api/api.go 56.69% <0.00%> (-0.76%) ⬇️
.../consensus/tendermint/apps/registry/state/state.go 60.55% <0.00%> (-0.56%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417f861...0fbc915. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/txpool-txsync-force branch from 12dd4f8 to 0fbc915 Compare April 4, 2022 10:33
@kostko kostko marked this pull request as ready for review April 4, 2022 10:56
@kostko kostko merged commit 9c73122 into master Apr 4, 2022
@kostko kostko deleted the kostko/fix/txpool-txsync-force branch April 4, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants