go/worker/compute: Improve proposed transaction handling #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/txpool-sync
branch
9 times, most recently
from
510c9ad
to
3669db3
Compare
kostko
requested review from
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
force-pushed
the
kostko/fix/txpool-sync
branch
from
3669db3
to
6670997
Compare
Codecov Report
@@ Coverage Diff @@
## master #4640 +/- ##
==========================================
+ Coverage 67.05% 67.10% +0.05%
==========================================
Files 431 431
Lines 48818 48870 +52
==========================================
+ Hits 32735 32796 +61
+ Misses 12050 12049 -1
+ Partials 4033 4025 -8
Continue to review full report at Codecov.
|
Yawning
reviewed
Apr 5, 2022
go/runtime/txpool/txpool.go
Outdated
| @@ -303,9 +359,10 @@ func (t *txPool) GetPrioritizedBatch(offset *hash.Hash, limit uint32) []*transac | |||
|
|
|||
| func (t *txPool) GetKnownBatch(batch []hash.Hash) ([]*transaction.CheckedTransaction, map[hash.Hash]int) { | |||
| t.schedulerLock.Lock() | |||
| defer t.schedulerLock.Unlock() | |||
| schedulerQueue := t.schedulerQueue | |||
There was a problem hiding this comment.
This is spooky, I take it this is to avoid adding GetKnownBatchLocked?
kostko
force-pushed
the
kostko/fix/txpool-sync
branch
from
6670997
to
ac161d9
Compare
kostko
force-pushed
the
kostko/fix/txpool-sync
branch
from
ac161d9
to
bfd33c3
Compare
Yawning
approved these changes
Apr 5, 2022
ptrus
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.