go/runtime/host: Always emit StoppedEvent on stop #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
requested review from
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
Previously the StoppedEvent was only emitted in case the runtime was previously running. In case multihost was performing a version switch when a runtime was not yet started, this resulted in a deadlock.
kostko
force-pushed
the
kostko/fix/multihost-stop-deadlock
branch
from
460686a
to
6aab8d5
Compare
Yawning
approved these changes
Apr 7, 2022
ptrus
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
StoppedEventwas only emitted in case the runtime waspreviously running. In case multihost was performing a version switch
when a runtime was not yet started, this resulted in a deadlock.