Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/storage: Make checkpoint sync peer selection smarter #4671

Merged
merged 4 commits into from
Apr 15, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 15, 2022

No description provided.

@kostko kostko added the c:storage Category: storage label Apr 15, 2022
@kostko kostko force-pushed the kostko/feature/storage-sync-checkpoint-peer-priority branch from f5d0e7b to 88d79a6 Compare April 15, 2022 11:11
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #4671 (6918e72) into master (8381b14) will decrease coverage by 0.00%.
The diff coverage is 91.76%.

@@            Coverage Diff             @@
##           master    #4671      +/-   ##
==========================================
- Coverage   66.92%   66.91%   -0.01%     
==========================================
  Files         432      432              
  Lines       48637    48662      +25     
==========================================
+ Hits        32551    32564      +13     
- Misses      12068    12081      +13     
+ Partials     4018     4017       -1     
Impacted Files Coverage Δ
go/worker/common/p2p/rpc/client.go 80.75% <78.94%> (+2.57%) ⬆️
go/worker/storage/committee/checkpoint_sync.go 63.98% <88.88%> (-3.80%) ⬇️
go/storage/mkvs/checkpoint/checkpointer.go 84.35% <100.00%> (+0.84%) ⬆️
go/worker/storage/p2p/sync/client.go 91.30% <100.00%> (+4.20%) ⬆️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/worker/common/committee/p2p.go 70.00% <0.00%> (-16.67%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/consensus/tendermint/full/light.go 57.69% <0.00%> (-3.85%) ⬇️
go/worker/storage/p2p/sync/server.go 74.19% <0.00%> (-3.23%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb33bf9...6918e72. Read the comment docs.

@kostko kostko marked this pull request as ready for review April 15, 2022 11:54
@kostko kostko merged commit 8fe6a1f into master Apr 15, 2022
@kostko kostko deleted the kostko/feature/storage-sync-checkpoint-peer-priority branch April 15, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants