Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/compute: Start batch resolution early for backup worker #4679

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 21, 2022

No description provided.

@kostko kostko force-pushed the kostko/feature/rt-executor-backup-earlyresolve branch from 2d29f5f to 406c494 Compare April 21, 2022 08:44
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #4679 (406c494) into master (178c85f) will decrease coverage by 0.50%.
The diff coverage is 82.69%.

@@            Coverage Diff             @@
##           master    #4679      +/-   ##
==========================================
- Coverage   67.41%   66.90%   -0.51%     
==========================================
  Files         436      436              
  Lines       48890    48915      +25     
==========================================
- Hits        32957    32728     -229     
- Misses      11893    12140     +247     
- Partials     4040     4047       +7     
Impacted Files Coverage Δ
go/worker/compute/executor/committee/node.go 69.83% <66.66%> (-1.98%) ⬇️
.../worker/compute/executor/committee/transactions.go 84.09% <86.04%> (-1.40%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/runtime/host/sandbox/sandbox.go 59.85% <0.00%> (-16.20%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/runtime/host/multi/multi.go 70.58% <0.00%> (-6.62%) ⬇️
go/oasis-node/cmd/ias/auth.go 71.87% <0.00%> (-6.25%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 63.63% <0.00%> (-6.07%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178c85f...406c494. Read the comment docs.

Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, are you going to fix/implement the TODO items?

@kostko
Copy link
Member Author

kostko commented Apr 21, 2022

Sure, are you going to fix/implement the TODO items?

Those have been transferred over from existing code and should be taken care of in a separate PR IMO.

@Yawning
Copy link
Contributor

Yawning commented Apr 21, 2022

Sure, are you going to fix/implement the TODO items?

Those have been transferred over from existing code and should be taken care of in a separate PR IMO.

Alright

@kostko kostko merged commit 9f399d0 into master Apr 21, 2022
@kostko kostko deleted the kostko/feature/rt-executor-backup-earlyresolve branch April 21, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants