go/runtime/host/sandbox: Properly handle clone3 in seccomp policy #4687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to handle the clone3 syscall in a special manner as there are
several complications to its handling:
Newer glibc versions will try clone3 first and if they see EPERM they
will instantly fail making the program unable to spawn threads.
The clone3 syscall is much more complex than clone and so we can't
simply inspect its flags as above for clone.
Therefore we need to reject the syscall with ENOSYS, causing fallback to
clone.