go/oasis-node/cmd: unsafe-reset check datadir validity #4702
Conversation
ptrus
requested review from
kostko,
Yawning,
peterjgilbert and
pro-wh
as code owners
ptrus
force-pushed
the
ptrus/feature/unsafe-reset-datadir
branch
from
c841ecd
to
964ddd2
Compare
| @@ -67,6 +68,21 @@ func doUnsafeReset(cmd *cobra.Command, args []string) { | |||
| return | |||
| } | |||
|
|
|||
| // Do a state dir sanity check. | |||
| glob := filepath.Join(dataDir, tendermintCommon.StateDir) | |||
There was a problem hiding this comment.
Could maybe check for some other files/folders as well
There was a problem hiding this comment.
Maybe identity.NodeKeyPubFilename as well?
ptrus
force-pushed
the
ptrus/feature/unsafe-reset-datadir
branch
3 times, most recently
from
2c83399
to
4b1d03e
Compare
Codecov Report
@@ Coverage Diff @@
## master #4702 +/- ##
==========================================
- Coverage 67.18% 66.86% -0.32%
==========================================
Files 436 436
Lines 48977 48990 +13
==========================================
- Hits 32906 32758 -148
- Misses 12014 12188 +174
+ Partials 4057 4044 -13
Continue to review full report at Codecov.
|
| return | ||
| } | ||
| if len(matches) == 0 && !cmdFlags.Force() { | ||
| fmt.Printf("Expected path: '%s' not found. Not removing any files. Use --force to run the command regardless.\n", glob) |
There was a problem hiding this comment.
Maybe just say something like:
| fmt.Printf("Expected path: '%s' not found. Not removing any files. Use --force to run the command regardless.\n", glob) | |
| fmt.Printf("%s does not look like an oasis-node data directory, not removing any files. Use --force to run the command regardless.\n", dataDir) |
| // Completely reset state for one of the compute nodes so we can test initial sync. | ||
| sc.Logger.Info("completely resetting state for one of the compute nodes") | ||
| cli := cli.New(childEnv, sc.Net, sc.Logger) | ||
| if err = cli.UnsafeReset(sc.Net.ComputeWorkers()[1].DataDir(), false, false); err != nil { | ||
| if err = cli.UnsafeReset(sc.Net.ComputeWorkers()[1].DataDir(), false, false, true); err != nil { |
There was a problem hiding this comment.
Because unsafe-reset is already run for all nodes in the DumpRestoreNetwork, so the tendermint directory will already be cleared on this node that we run unsafe-reset (without perserving any runtime dirs) again.
ptrus
force-pushed
the
ptrus/feature/unsafe-reset-datadir
branch
from
4b1d03e
to
3c16987
Compare
No description provided.