go/worker/common/p2p: Add support for persistent and blocked peers #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abukosek
force-pushed
the
andrej/feature/p2p-blacklist
branch
2 times, most recently
from
31c6a67
to
ca9a83f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4713 +/- ##
==========================================
- Coverage 66.77% 66.71% -0.06%
==========================================
Files 441 441
Lines 49348 49407 +59
==========================================
+ Hits 32952 32963 +11
- Misses 12317 12375 +58
+ Partials 4079 4069 -10
Continue to review full report at Codecov.
|
abukosek
force-pushed
the
andrej/feature/p2p-blacklist
branch
2 times, most recently
from
8715c86
to
51dadc3
Compare
abukosek
force-pushed
the
andrej/feature/p2p-blacklist
branch
from
51dadc3
to
e8a00b6
Compare
abukosek
requested review from
kostko,
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
reviewed
May 16, 2022
There was a problem hiding this comment.
You could probably use pubsub.WithDirectPeers to make the pubsub router maintain those connections. That option also supports specifying IP addresses, see here for how this is implemented.
abukosek
force-pushed
the
andrej/feature/p2p-blacklist
branch
3 times, most recently
from
a0524ad
to
db8fd41
Compare
kostko
approved these changes
May 18, 2022
go/worker/common/p2p/p2p.go
Outdated
| return nil, fmt.Errorf("worker/common/p2p: invalid persistent peer public key (%s): %w", pubkey, grr) | ||
| } | ||
|
|
||
| ipport := strings.Split(addr, ":") |
There was a problem hiding this comment.
Should probably use net.SplitHostPort.
abukosek
force-pushed
the
andrej/feature/p2p-blacklist
branch
from
db8fd41
to
9df6aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for blocking p2p peers and for keeping persistent connections to peers.
The persistent peer functionality currently doesn't automatically connect to the given peers on startup, but will only keep the connection once it's already established.