Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/txpool: Add txpool metric for rejected runtime transactions #4724

Merged
merged 1 commit into from May 3, 2022

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented May 3, 2022

No description provided.

@ptrus ptrus force-pushed the ptrus/feature/rejected-transactions branch from 78b32f2 to 755e1ed Compare May 3, 2022 07:22
@ptrus ptrus marked this pull request as ready for review May 3, 2022 07:22
@ptrus ptrus force-pushed the ptrus/feature/rejected-transactions branch from 755e1ed to 06e955c Compare May 3, 2022 07:36
@ptrus ptrus force-pushed the ptrus/feature/rejected-transactions branch from 06e955c to dbd8852 Compare May 3, 2022 07:40
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #4724 (dbd8852) into master (22ee108) will decrease coverage by 0.06%.
The diff coverage is 87.93%.

@@            Coverage Diff             @@
##           master    #4724      +/-   ##
==========================================
- Coverage   66.86%   66.80%   -0.07%     
==========================================
  Files         440      440              
  Lines       49224    49228       +4     
==========================================
- Hits        32916    32885      -31     
- Misses      12252    12287      +35     
  Partials     4056     4056              
Impacted Files Coverage Δ
go/runtime/txpool/metrics.go 100.00% <ø> (ø)
go/runtime/registry/config.go 70.68% <33.33%> (-0.83%) ⬇️
go/worker/common/committee/keymanager.go 89.47% <89.47%> (ø)
go/worker/compute/executor/committee/node.go 71.08% <90.00%> (-0.33%) ⬇️
go/runtime/txpool/txpool.go 77.97% <100.00%> (+0.62%) ⬆️
go/worker/common/committee/node.go 61.04% <100.00%> (+1.66%) ⬆️
go/worker/common/committee/runtime_host.go 50.00% <100.00%> (ø)
go/runtime/host/sandbox/sandbox.go 59.85% <0.00%> (-6.70%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 63.63% <0.00%> (-6.07%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 47.22% <0.00%> (-5.56%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d666f80...dbd8852. Read the comment docs.

@ptrus ptrus merged commit 99c2c5d into master May 3, 2022
@ptrus ptrus deleted the ptrus/feature/rejected-transactions branch May 3, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants