Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/config: fix SGX provisioner check #4734

Merged
merged 1 commit into from
May 5, 2022

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented May 5, 2022

TODO:

  • test

This should fix the SGX provisioner check. Currently SGX provisioner needs to be set even for non-sgx runtimes, caused by: #4734

@ptrus ptrus added the s:ready-ci Status: ready for CI label May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #4734 (84e8ba4) into master (3f56208) will increase coverage by 0.06%.
The diff coverage is 82.35%.

❗ Current head 84e8ba4 differs from pull request most recent head 076149d. Consider uploading reports for the commit 076149d to get more accurate results

@@            Coverage Diff             @@
##           master    #4734      +/-   ##
==========================================
+ Coverage   66.86%   66.92%   +0.06%     
==========================================
  Files         440      441       +1     
  Lines       49254    49340      +86     
==========================================
+ Hits        32934    33023      +89     
+ Misses      12280    12262      -18     
- Partials     4040     4055      +15     
Impacted Files Coverage Δ
go/runtime/registry/config.go 69.88% <0.00%> (-0.81%) ⬇️
go/runtime/host/logger.go 78.68% <78.68%> (ø)
go/common/logging/logging.go 76.07% <90.90%> (-1.85%) ⬇️
go/runtime/host/sandbox/sandbox.go 70.10% <100.00%> (+10.24%) ⬆️
go/runtime/host/sgx/sgx.go 70.25% <100.00%> (+1.10%) ⬆️
go/common/cbor/codec.go 78.37% <0.00%> (-10.82%) ⬇️
go/worker/common/p2p/rpc/server.go 80.76% <0.00%> (-9.62%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 63.63% <0.00%> (-6.07%) ⬇️
go/worker/common/committee/keymanager.go 89.47% <0.00%> (-5.27%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 68.81% <0.00%> (-4.31%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2713b0...076149d. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/fix/sgx-provisioner-nosgx branch 2 times, most recently from 6537cfc to 27738da Compare May 5, 2022 17:07
@ptrus ptrus marked this pull request as ready for review May 5, 2022 17:14
@ptrus ptrus force-pushed the ptrus/fix/sgx-provisioner-nosgx branch from 27738da to 076149d Compare May 5, 2022 17:16
.changelog/4734.bugfix.md Outdated Show resolved Hide resolved
@ptrus ptrus enabled auto-merge May 5, 2022 17:27
@ptrus ptrus merged commit fd42995 into master May 5, 2022
@ptrus ptrus deleted the ptrus/fix/sgx-provisioner-nosgx branch May 5, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:ready-ci Status: ready for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants