runtime: Add support for reporting EnclaveRPC peer feedback #4757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/enclaverpc-improvements
branch
2 times, most recently
from
e48c85b
to
f583c5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #4757 +/- ##
==========================================
+ Coverage 66.55% 66.66% +0.11%
==========================================
Files 446 447 +1
Lines 50031 50065 +34
==========================================
+ Hits 33299 33377 +78
+ Misses 12562 12538 -24
+ Partials 4170 4150 -20
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/enclaverpc-improvements
branch
from
f583c5b
to
619317b
Compare
This makes EnclaveRPC more robust as the higher-level layer in the runtime can trigger peer replacement on high level errors.
kostko
force-pushed
the
kostko/feature/enclaverpc-improvements
branch
from
619317b
to
4d28425
Compare
kostko
requested review from
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
ptrus
reviewed
May 24, 2022
| return &protocol.Body{HostRPCCallResponse: &protocol.HostRPCCallResponse{ | ||
| Response: cbor.FixSliceForSerde(rsp.Data), | ||
| Response: cbor.FixSliceForSerde(rsp), |
There was a problem hiding this comment.
Btw is this FixSliceForSerde still needed? serde is not used anymore for cbor serialization, right?
There was a problem hiding this comment.
True, we could fix it in oasis-cbor, but currently it also doesn't allow deserialization into vectors from NULL, so it is still needed. Will open an issue for it though.
ptrus
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes EnclaveRPC more robust as the higher-level layer in the
runtime can trigger peer replacement on high level errors.
TODO
KeyManagerClientWrapperin the key manager worker.