Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Add consensus.tendermint.halt_height #4793

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 10, 2022

This is equivalent to the cosmos halt-height option, to be used to
bring a node down gracefully at a specific height. Hopefully this will
never need to be used.

This is equivalent to the cosmos `halt-height` option, to be used to
bring a node down gracefully at a specific height.  Hopefully this will
never need to be used.
@Yawning Yawning force-pushed the yawning/feature/halt-height branch from cb11820 to aba5861 Compare June 10, 2022 03:51
@Yawning Yawning marked this pull request as ready for review June 10, 2022 03:51
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #4793 (aba5861) into master (2a86f51) will decrease coverage by 0.13%.
The diff coverage is 65.21%.

@@            Coverage Diff             @@
##           master    #4793      +/-   ##
==========================================
- Coverage   66.99%   66.85%   -0.14%     
==========================================
  Files         451      451              
  Lines       50289    50300      +11     
==========================================
- Hits        33690    33630      -60     
- Misses      12443    12500      +57     
- Partials     4156     4170      +14     
Impacted Files Coverage Δ
go/consensus/tendermint/abci/mux.go 58.37% <50.00%> (-1.57%) ⬇️
go/consensus/tendermint/abci/state.go 74.28% <64.70%> (-2.55%) ⬇️
go/consensus/tendermint/full/full.go 66.73% <100.00%> (+1.49%) ⬆️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/runtime/host/sandbox/sandbox.go 60.82% <0.00%> (-15.81%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/common/grpc/grpc.go 79.88% <0.00%> (-4.44%) ⬇️
go/runtime/host/multi/multi.go 70.58% <0.00%> (-4.42%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64f84a8...aba5861. Read the comment docs.

@Yawning Yawning merged commit 2125e73 into master Jun 10, 2022
@Yawning Yawning deleted the yawning/feature/halt-height branch June 10, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants