go/oasis-node: allow km to have private peers #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
requested review from
kostko,
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
nhynes
commented
Jun 25, 2022
| func (net *Network) generateTempSocketPath() string { | ||
| f, err := ioutil.TempFile(env.GetRootDir().String(), "internal-*.sock") | ||
| func (net *Network) generateTempSocketPath(prefix string) string { | ||
| f, err := ioutil.TempFile(env.GetRootDir().String(), fmt.Sprintf("%s-internal-*.sock", prefix)) |
There was a problem hiding this comment.
this is nice for debugging
Yawning
approved these changes
Jun 25, 2022
|
Just FYI, I can't run the CI. |
nhynes
force-pushed
the
nhynes/km-private-peers
branch
from
c1b01c4
to
16fac68
Compare
Yawning
reviewed
Jun 27, 2022
nhynes
force-pushed
the
nhynes/km-private-peers
branch
from
16fac68
to
56331ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #4821 +/- ##
=======================================
Coverage 66.64% 66.64%
=======================================
Files 451 452 +1
Lines 50310 50334 +24
=======================================
+ Hits 33529 33547 +18
- Misses 12620 12636 +16
+ Partials 4161 4151 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private peers are libp2p peers which are added manually and are not advertised. The goal is to allow client nodes that the key manager likes to access km methods, which is used by the confidential evm paratime's signed queries.