Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil deference bugs and add tests #4822

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 27, 2022

This was already fixed in (recent) 22.1.x releases.

@ptrus ptrus force-pushed the ptrus/feature/fix-nil-deser branch from 17a4a08 to 368581c Compare June 27, 2022 07:11
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #4822 (368581c) into master (99af6b7) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4822      +/-   ##
==========================================
- Coverage   66.71%   66.56%   -0.16%     
==========================================
  Files         451      451              
  Lines       50302    50307       +5     
==========================================
- Hits        33561    33488      -73     
- Misses      12588    12653      +65     
- Partials     4153     4166      +13     
Impacted Files Coverage Δ
go/registry/api/api.go 57.42% <100.00%> (+1.03%) ⬆️
go/registry/api/runtime.go 49.09% <100.00%> (+1.15%) ⬆️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/runtime/host/sandbox/sandbox.go 60.82% <0.00%> (-6.53%) ⬇️
go/runtime/host/multi/multi.go 70.58% <0.00%> (-4.42%) ⬇️
go/worker/compute/executor/committee/node.go 69.22% <0.00%> (-4.06%) ⬇️
go/consensus/tendermint/full/light.go 61.53% <0.00%> (-3.85%) ⬇️
go/runtime/host/protocol/connection.go 68.42% <0.00%> (-3.76%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.66% <0.00%> (-3.12%) ⬇️
go/oasis-node/cmd/stake/delegations.go 78.99% <0.00%> (-1.69%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b46234...368581c. Read the comment docs.

@ptrus ptrus merged commit 8ca9b1b into master Jun 27, 2022
@ptrus ptrus deleted the ptrus/feature/fix-nil-deser branch June 27, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants