Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: fix verify state for historical queries #4830

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 29, 2022

No description provided.

@ptrus ptrus force-pushed the ptrus/fix/queries-verify-historic branch 3 times, most recently from 3d1e24d to 0abf8ea Compare June 30, 2022 13:52
@ptrus ptrus marked this pull request as ready for review June 30, 2022 13:52
@ptrus ptrus force-pushed the ptrus/fix/queries-verify-historic branch from 0abf8ea to 57692e8 Compare July 1, 2022 06:27
@ptrus ptrus enabled auto-merge July 1, 2022 06:33
@ptrus ptrus disabled auto-merge July 1, 2022 06:36
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #4830 (57692e8) into master (cdf8224) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4830      +/-   ##
==========================================
+ Coverage   66.55%   66.62%   +0.07%     
==========================================
  Files         452      452              
  Lines       50336    50336              
==========================================
+ Hits        33500    33538      +38     
+ Misses      12673    12632      -41     
- Partials     4163     4166       +3     
Impacted Files Coverage Δ
go/worker/client/committee/node.go 75.48% <100.00%> (ø)
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.66% <0.00%> (-3.12%) ⬇️
go/worker/keymanager/watcher.go 63.07% <0.00%> (-3.08%) ⬇️
go/consensus/tendermint/abci/state.go 72.85% <0.00%> (-2.86%) ⬇️
go/storage/mkvs/insert.go 87.75% <0.00%> (-2.73%) ⬇️
go/runtime/host/protocol/connection.go 69.17% <0.00%> (-2.26%) ⬇️
go/storage/mkvs/lookup.go 77.08% <0.00%> (-2.09%) ⬇️
go/worker/beacon/worker_vrf.go 66.08% <0.00%> (-1.74%) ⬇️
go/oasis-node/cmd/stake/delegations.go 78.99% <0.00%> (-1.69%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83c83f...57692e8. Read the comment docs.

@ptrus ptrus merged commit f37c033 into master Jul 1, 2022
@ptrus ptrus deleted the ptrus/fix/queries-verify-historic branch July 1, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants