Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymanager: Refactor and reorganize runtime-related crates #4930

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

peternose
Copy link
Contributor

Currently there is a bunch of runtime-related crates, where the split is mostly for legacy reasons. We should consider how to consolidate these crates so that it makes them easier to maintain. The current crates are as follows:

  • oasis-core-client (client/), could be moved into oasis-core-runtime.
  • oasis-core-keymanager-* (keymanager-*/), some (APIs?) could be moved into oasis-core-runtime, some (KM implementation) could be consolidated under a single crate.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #4930 (98bc4da) into master (06012a8) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4930      +/-   ##
==========================================
- Coverage   66.64%   66.62%   -0.03%     
==========================================
  Files         464      464              
  Lines       51204    51204              
==========================================
- Hits        34127    34113      -14     
- Misses      12891    12901      +10     
- Partials     4186     4190       +4     
Impacted Files Coverage Δ
go/common/version/version.go 80.26% <ø> (ø)
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
.../worker/compute/executor/committee/transactions.go 79.54% <0.00%> (-9.10%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.66% <0.00%> (-3.12%) ⬇️
go/worker/common/p2p/rpc/client.go 80.93% <0.00%> (-2.80%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 65.81% <0.00%> (-2.57%) ⬇️
go/runtime/txpool/txpool.go 82.70% <0.00%> (-2.44%) ⬇️
...nsensus/tendermint/apps/beacon/backend_insecure.go 58.24% <0.00%> (-2.20%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 68.81% <0.00%> (-2.16%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternose peternose force-pushed the peternose/internal/refactor-keymanager-crates branch 3 times, most recently from e84503f to 39ffa49 Compare September 13, 2022 06:09
@peternose peternose marked this pull request as ready for review September 13, 2022 06:10
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

keymanager/src/api/requests.rs Outdated Show resolved Hide resolved
keymanager/src/crypto/types.rs Outdated Show resolved Hide resolved
keymanager/src/policy/signers.rs Outdated Show resolved Hide resolved
@peternose peternose force-pushed the peternose/internal/refactor-keymanager-crates branch from 39ffa49 to 98bc4da Compare September 13, 2022 13:24
@peternose peternose merged commit 97dc864 into master Sep 13, 2022
@peternose peternose deleted the peternose/internal/refactor-keymanager-crates branch September 13, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants