go/runtime/txpool: Add block propagation delay before tx publish #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After processing a new block locally, make sure that any transactions that are checked against that block are only propagated after waiting for the newBlockPublishDelay to increase probability that peers are up to date with the new block. Obviously a better way would be to check the current round of each peer (e.g., via a p2p update protocol), but such filtering is unfortunately not possible to do with the current go-libp2p-pubsub implementation.
kostko
force-pushed
the
kostko/fix/txpool-delay-publish
branch
from
55c79b8
to
84a3e9b
Compare
Codecov Report
@@ Coverage Diff @@
## master #4959 +/- ##
==========================================
+ Coverage 66.61% 66.64% +0.03%
==========================================
Files 464 464
Lines 51222 51226 +4
==========================================
+ Hits 34120 34141 +21
+ Misses 12912 12885 -27
- Partials 4190 4200 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kostko
requested review from
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
|
oh is this to handle txs that are valid in the new block but invalid in the old block? |
|
Yes. |
Yawning
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After processing a new block locally, make sure that any transactions that are checked against that block are only propagated after waiting for the
newBlockPublishDelayto increase probability that peers are up to date with the new block.Obviously a better way would be to check the current round of each peer (e.g., via a p2p update protocol), but such filtering is unfortunately not possible to do with the current go-libp2p-pubsub implementation.