Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] add rel filter on emerald/transactions #314

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

Andrew7234
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM provided you tested e2e locally.

storage/client/queries.go Outdated Show resolved Hide resolved
storage/client/queries.go Outdated Show resolved Hide resolved
@Andrew7234
Copy link
Collaborator Author

tested e2e locally.

Yep tested locally and confirmed that the returned transactions are associated with the rel address. It should be noted that for evm.Call transactions, the rel address often only appears in the events associated with that transaction and is not displayed within the transaction itself (eg as sender or to). This can be checked by querying emerald/events?tx_hash={some_tx_hash} and inspecting the returned events for the rel address

@Andrew7234 Andrew7234 merged commit 5650e69 into main Feb 14, 2023
@Andrew7234 Andrew7234 deleted the andrew7234/emerald-rel-txs branch February 14, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants