Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM token balances analyzer #332

Merged
merged 8 commits into from
Mar 9, 2023
Merged

EVM token balances analyzer #332

merged 8 commits into from
Mar 9, 2023

Conversation

pro-wh
Copy link
Collaborator

@pro-wh pro-wh commented Feb 25, 2023

an analyzer to download token contracts' opinion of what accounts' balances are

analyzer/queries.go Outdated Show resolved Hide resolved
@pro-wh pro-wh force-pushed the pro-wh/feature/holders8 branch 2 times, most recently from 8cadd2c to 3f37f27 Compare March 3, 2023 01:09
@pro-wh pro-wh force-pushed the pro-wh/feature/holders8 branch 2 times, most recently from 0c57bc4 to 5dc21aa Compare March 4, 2023 03:03
@pro-wh pro-wh changed the base branch from main to pro-wh/bugfix/batch March 4, 2023 03:03
Base automatically changed from pro-wh/bugfix/batch to main March 6, 2023 21:56
@pro-wh pro-wh marked this pull request as ready for review March 6, 2023 23:57
@pro-wh pro-wh changed the title (unfinished) EVM token balances analyzer EVM token balances analyzer Mar 8, 2023
@pro-wh
Copy link
Collaborator Author

pro-wh commented Mar 8, 2023

little weirdness: the token balance row will exist before we first download the token balance. this allows us to start collecting changes from evm logs while we asynchronously download the balance for the first time. this is different from the token db, where we don't do any reckoning on the total supply, and we don't create the token row until we download the token data for the first time.

Copy link
Collaborator

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM but holding off on a formal LGTM because one or two of my questions make me think I'm possibly missing a little nuance.

analyzer/evmtokenbalances/evm_token_balances.go Outdated Show resolved Hide resolved
analyzer/evmtokenbalances/evm_token_balances.go Outdated Show resolved Hide resolved
analyzer/evmtokenbalances/evm_token_balances.go Outdated Show resolved Hide resolved
analyzer/evmtokenbalances/evm_token_balances.go Outdated Show resolved Hide resolved
analyzer/modules/evm.go Show resolved Hide resolved
analyzer/modules/evm.go Show resolved Hide resolved
analyzer/queries/queries.go Show resolved Hide resolved
Copy link
Collaborator

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pro-wh pro-wh merged commit e220d3f into main Mar 9, 2023
@pro-wh pro-wh deleted the pro-wh/feature/holders8 branch March 9, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants