-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM token balances analyzer #332
Conversation
12c9dc7
to
247c27b
Compare
247c27b
to
a3a330f
Compare
a3a330f
to
dd25cf1
Compare
8cadd2c
to
3f37f27
Compare
0c57bc4
to
5dc21aa
Compare
51626a4
to
6f48594
Compare
5dc21aa
to
e58a4e9
Compare
e58a4e9
to
044abfc
Compare
044abfc
to
907fb35
Compare
little weirdness: the token balance row will exist before we first download the token balance. this allows us to start collecting changes from evm logs while we asynchronously download the balance for the first time. this is different from the token db, where we don't do any reckoning on the total supply, and we don't create the token row until we download the token data for the first time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM but holding off on a formal LGTM because one or two of my questions make me think I'm possibly missing a little nuance.
907fb35
to
fdf0e6e
Compare
f9824d9
to
5af6e3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
an analyzer to download token contracts' opinion of what accounts' balances are