analyzer: remove concurrency in runtime analyzer #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
reviewed
Mar 3, 2023
Andrew7234
force-pushed
the
andrew7234/batch-query
branch
from
eb8e4c4
to
edd90fc
Compare
ptrus
reviewed
Mar 3, 2023
ptrus
reviewed
Mar 7, 2023
ptrus
reviewed
Mar 9, 2023
Andrew7234
force-pushed
the
andrew7234/batch-query
branch
from
cb873ab
to
2eb9908
Compare
analyzer: make storage.QueryBatch goroutine-safe analyzer: lock other storageBatch methods analyzer: lock other storageBatch address comments
Andrew7234
force-pushed
the
andrew7234/batch-query
branch
from
2eb9908
to
b910d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way to resolve #339
This PR removes concurrency from the runtime analyzer. It also refactors the runtime analyzer to fetch all the data initially and then process it sequentially, similar to the consensus analyzer.
Open Question:
storage.QueryBatch? (see the second commit) During local testing, the additional lock/unlock did not degrade the analyzer speed since the bottleneck is the network requests to the node. Although this mutex is now unnecessary, having a thread-safeQueryBatchwould prevent this type of bug from sneaking in (again) though.