config: archive node configuration #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
force-pushed
the
pro-wh/feature/holders8
branch
2 times, most recently
from
f9824d9
to
5af6e3b
Compare
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
from
6a5ad63
to
0814e65
Compare
mitjat
reviewed
Mar 10, 2023
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
from
0814e65
to
0e323dc
Compare
ptrus
force-pushed
the
ptrus/feature/runtime-stats
branch
3 times, most recently
from
ffdf094
to
d458a66
Compare
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
from
0e323dc
to
b950630
Compare
pro-wh
commented
Mar 14, 2023
pro-wh
commented
Mar 14, 2023
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
from
b950630
to
879540c
Compare
pro-wh
commented
Mar 14, 2023
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
2 times, most recently
from
d88d2a1
to
dcc64ff
Compare
pro-wh
commented
Mar 16, 2023
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
from
dcc64ff
to
dd2bdd4
Compare
|
aaah I gotta update a bunch of test code |
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
from
dd2bdd4
to
43d8a1d
Compare
pro-wh
commented
Mar 17, 2023
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
from
43d8a1d
to
4569743
Compare
|
ugh and the docker e2e test doesn't have the right configs and stuff |
|
alright let's allow there to be a single-oasis-node-with-given-chain-context setting as well. |
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
7 times, most recently
from
a719bdd
to
faef8ed
Compare
|
gotta update those e2e test configs |
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
3 times, most recently
from
b8880b6
to
aa35fc3
Compare
Merged
mitjat
approved these changes
Apr 5, 2023
storage/oasis/nodeapi/history/sdk.go
Outdated
|
|
||
| // SDKConnect creates an Oasis SDK Connection to a node running the current | ||
| // version of oasis-node. | ||
| func SDKConnect(ctx context.Context, chainContext string, nodeConfig *config.NodeConfig, fastStartup bool) (connection.Connection, error) { |
There was a problem hiding this comment.
Nit, nonblocking: Not sure this has to do with history much ... Can you think of a better home? storage/oasis? Same for raw_grpc.go.
There was a problem hiding this comment.
oh ok I can move these into a separate directory 👍
|
|
pro-wh
force-pushed
the
pro-wh/feature/cobaltconf
branch
from
aa35fc3
to
24d18cb
Compare
mitjat
approved these changes
Apr 7, 2023
turns out server.chain_name in the config is only used to convert the runtime name to its ID Co-authored-by: mitjat <mitjat@users.noreply.github.com>
lukaw3d
reviewed
May 1, 2023
Comment on lines
1022
to
-1027
| required: [latest_chain_id, latest_block, latest_update] | ||
| properties: | ||
| latest_chain_id: | ||
| x-go-name: LatestChainID # oapi-codegen generates LatestChainId (with a lowercase d) by default. |
There was a problem hiding this comment.
Leftover latest_chain_id in required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new config format to allow setting multiple nodes, for archive access. see the sample configs for how to migrate your config files.
indexer devs: no more client factory system. just create a consensus client or runtime client directly. see existing analyzers for how to do this.
indexer devs: the analyzer no longer runs with a set chain context. in general, don't verify signatures. our node(s) will do that.