Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{runtime}/status: Endpoint for current number of compute nodes #354

Merged
merged 1 commit into from
Mar 13, 2023
Merged

{runtime}/status: Endpoint for current number of compute nodes #354

merged 1 commit into from
Mar 13, 2023

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 10, 2023 •
edited
Loading

Testing (on some early damask mainnet blocks):

curl "http://localhost:8008/v1/emerald/status"
{"active_nodes":57,"latest_block":8053413,"latest_update":"2023-03-10T16:21:45Z"}

curl "http://localhost:8008/v1/cipher/status"
{"active_nodes":9,"latest_block":8053698,"latest_update":"2023-03-10T16:22:32Z"}

curl "http://localhost:8008/v1/wrong/status"
{"msg":"Invalid format for parameter runtime: not a valid enum value: wrong"}

Deployment

This PR adds a new required parameter that needs to be included in the deployment config:

server:
  chain_name: mainnet # (or testnet on the testnet indexer)

@ptrus ptrus force-pushed the ptrus/feature/runtime-stats branch 3 times, most recently from 0158d2c to e3b7707 Compare March 10, 2023 17:11
aefhm
aefhm reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@aefhm aefhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing we also have a trailing private-ops change then.

aefhm
aefhm approved these changes Mar 13, 2023
View reviewed changes
analyzer/consensus/consensus.go Outdated Show resolved Hide resolved
mitjat
mitjat reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

tests/e2e_regression/reindex_and_run.sh Show resolved Hide resolved
api/spec/v1.yaml Outdated Show resolved Hide resolved
storage/client/client.go Show resolved Hide resolved
analyzer/consensus/consensus.go Show resolved Hide resolved
api/spec/v1.yaml Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/runtime-stats branch 2 times, most recently from e3947ce to ffdf094 Compare March 13, 2023 20:46
mitjat
mitjat approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additional changes!

@ptrus ptrus force-pushed the ptrus/feature/runtime-stats branch from ffdf094 to d458a66 Compare March 13, 2023 23:33
@ptrus
Copy link
Member Author

ptrus commented Mar 13, 2023

I'm guessing we also have a trailing private-ops change then.

Opened a PR: https://github.com/oasislabs/private-ops/pull/2648

@ptrus ptrus merged commit 2e4d35a into main Mar 13, 2023
@ptrus ptrus deleted the ptrus/feature/runtime-stats branch March 13, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-wh pro-wh pro-wh left review comments

@mitjat mitjat mitjat approved these changes

@aefhm aefhm aefhm approved these changes

@Andrew7234 Andrew7234 Awaiting requested review from Andrew7234 Andrew7234 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ptrus @mitjat @aefhm @pro-wh